Skip to content

Upgrade to use jcasc test harness - #284

Merged
dwnusbaum merged 1 commit into
jenkinsci:masterfrom
timja:upgrade-jcasc
Jan 27, 2020
Merged

Upgrade to use jcasc test harness#284
dwnusbaum merged 1 commit into
jenkinsci:masterfrom
timja:upgrade-jcasc

Conversation

@timja

@timja timja commented Jan 14, 2020

Copy link
Copy Markdown
Member

JCasc had to create a new dependency that wasn't a tests classifier because maven doesn't allow you to bring dependencies through classifiers.

Upgrading here so that PCT works again,

Tracking:
jenkinsci/bom#164

Note: We'll need a release for PCT please

@timja timja mentioned this pull request Jan 14, 2020
Merged
@timja
timja requested a review from dwnusbaum January 16, 2020 21:35
@timja timja mentioned this pull request Jan 18, 2020
Merged
@jetersen

jetersen commented Jan 20, 2020

Copy link
Copy Markdown
Member

@dwnusbaum chance we could get a review/merge only one left blocking jenkinsci/bom#172 😅

@timja

timja commented Jan 20, 2020

Copy link
Copy Markdown
Member Author

@dwnusbaum chance we could get a review/merge only one left blocking jenkinsci/bom#172 😅

there's a few more 😉, the pipeline has failFast on the parallel block, each one we fix reveals more failures,

but would be great to get a review / merge / release

@timja
timja requested review from abayer and bitwiseman January 20, 2020 20:01
dwnusbaum
dwnusbaum approved these changes Jan 21, 2020
View reviewed changes

@dwnusbaum dwnusbaum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The new artifact pulls in a ton of dependencies, most notably jackson-databind, but we should never use any of those dependencies in this plugin in compile scope so I don't anticipate any conflicts that might require transitive dependencies to be excluded or anything.

@dwnusbaum
dwnusbaum requested a review from car-roll January 21, 2020 15:46
@timja

timja commented Jan 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

@dwnusbaum could you merge and release pretty please ❤️

@timja

timja commented Jan 24, 2020

Copy link
Copy Markdown
Member Author

or @bitwiseman :)

@dwnusbaum

dwnusbaum commented Jan 24, 2020

Copy link
Copy Markdown
Member

@timja My plan is to release this in the next week or so.

@dwnusbaum
dwnusbaum merged commit 6be6cee into jenkinsci:master Jan 27, 2020
@timja
timja deleted the upgrade-jcasc branch January 27, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes
@bitwiseman bitwiseman bitwiseman approved these changes
@car-roll car-roll car-roll approved these changes
@abayer abayer Awaiting requested review from abayer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@timja @jetersen @dwnusbaum @bitwiseman @car-roll